Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Setting CMAKE_CXX_STANDARD via Command Line in CMake #741

Closed
raghunandannm opened this issue Nov 16, 2023 · 0 comments · Fixed by #742
Closed

Allow Setting CMAKE_CXX_STANDARD via Command Line in CMake #741

raghunandannm opened this issue Nov 16, 2023 · 0 comments · Fixed by #742

Comments

@raghunandannm
Copy link

We at openPASS are planning to update protobuf to 3.22.0 or higher. However, for these versions of protobuf CMAKE_CXX_STANDARD 14 is required. But the CMAKELISTS.txt in open-simulation-interface hard-coded the CMAKE_CXX_STANDARD to 11. Therefore, it would be great if we there is an optional feature which also allows the user to set the CMAKE_CXX_STANDARD through command line.
pmai added a commit that referenced this issue Nov 20, 2023
@pmai
Make CMAKE_CXX_STANDARD overridable (fix #741)
15a43c1
pmai added a commit that referenced this issue Nov 20, 2023
@pmai
Make CMAKE_CXX_STANDARD overridable (fix #741)
95bd86a 
Signed-off-by: Pierre R. Mai <[email protected]>
pmai added a commit that referenced this issue Nov 22, 2023
@pmai
Make CMAKE_CXX_STANDARD overridable (fix #741)
423c0b2 
Signed-off-by: Pierre R. Mai <[email protected]>
pmai added a commit to pmai/open-simulation-interface that referenced this issue Jan 12, 2024
@pmai
Make CMAKE_CXX_STANDARD overridable (fix OpenSimulationInterface#741)
a1451fb 
Signed-off-by: Pierre R. Mai <[email protected]>
@jdsika jdsika mentioned this issue Jan 15, 2024
Merged
pmai added a commit that referenced this issue Jan 15, 2024
@pmai
Make CMAKE_CXX_STANDARD overridable (fix #741)
534daf5 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai pmai closed this as completed in #742 Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CMAKE_CXX_STANDARD overridable (fix #741) OpenSimulationInterface/open-simulation-interface
1 participant
@raghunandannm