Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transition/Mask replace_image Property #888

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Dec 20, 2022

This fixes a regression from a recent change to the Mask effect, which broke the replace_image property.

@jonoomph
Copy link
Member Author

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #888 (04db516) into develop (94e5f74) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #888   +/-   ##
========================================
  Coverage    51.95%   51.95%           
========================================
  Files          188      188           
  Lines        16394    16394           
========================================
  Hits          8518     8518           
  Misses        7876     7876           
Impacted Files Coverage Δ
src/effects/ColorShift.cpp 0.60% <0.00%> (ø)
src/effects/Mask.cpp 26.44% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph jonoomph merged commit 4fbb439 into develop Dec 20, 2022
@jonoomph jonoomph deleted the fix-transition-replace-image branch December 20, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant