Fixing regression with mask effect caused by contrast being adjusted …

…after we modulate the brightness (sort error)
OpenShot · Nov 18, 2022 · 553dcc6 · 553dcc6
1 parent 7617e91
commit 553dcc6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/effects/Mask.cpp b/src/effects/Mask.cpp
@@ -110,13 +110,13 @@ std::shared_ptr<openshot::Frame> Mask::GetFrame(std::shared_ptr<openshot::Frame>
 		// Get the average luminosity
 		int gray_value = qGray(R, G, B);
 
+        // Adjust the brightness
+        gray_value += (255 * brightness_value);
+
 		// Adjust the contrast
 		float factor = (259 * (contrast_value + 255)) / (255 * (259 - contrast_value));
 		gray_value = constrain((factor * (gray_value - 128)) + 128);
 
-		// Adjust the brightness
-		gray_value += (255 * brightness_value);
-
 		// Constrain the value from 0 to 255
 		gray_value = constrain(gray_value);