Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATH order at openrc-init #642

Closed
wants to merge 0 commits into from

Conversation

sulincix
Copy link

@sulincix sulincix commented Jul 28, 2023

This commit fix issue about #641

@vapier
Copy link
Member

vapier commented Aug 5, 2023

looks fine, but would be good to dig in the history a little first to see why it ended up this way

@WhyNotHugo
Copy link

path_default was defined in cfded51 which reads "This adds the default path setting from sysvinit.".

_PATH was defined initially in 0e6eb0f. There's no explanation of the order, it's simply been this way since it was initially defined.

@awilfox
Copy link

awilfox commented Jul 25, 2024

Would it be better to use getconf PATH (in shell) and confstr(_CS_PATH) (in C)? That is actually the most efficient way to determine a "default" PATH on a POSIX system.

Though, unfortunately, musl's _CS_PATH is /bin:/usr/bin, but that should probably be fixed upstream…

@navi-desu
Copy link
Member

Though, unfortunately, musl's _CS_PATH is /bin:/usr/bin, but that should probably be fixed upstream…

i'm running glibc, both getconf PATH and _CS_PATH also return /bin:/usr/bin

@sulincix
Copy link
Author

sulincix commented Jul 31, 2024

I think PATH variable defined by _CS_PATH. Or defined by /etc/profile or compile parameter.

I will recreate pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants