-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix review - removes all NFT related code #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the Ongoing+TieredPercentage implementations, interfaces, and methods in OpenQV1 and ClaimManagerV1
…quires token is whitelisted, or reverts
…ut a token address limit
…DDRESS_LIMIT, simply checks if token is whitelisted or not
…RESS_LIMIT in constructor
…RESS_LIMIT in the constructor
This was referenced Feb 26, 2023
IAm0x52
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Removes all logic from bounties. Seems to have gotten all related code. Will keep my out for any that was missed on when checking the rest of the PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the following methods from
AtomicBountyV1.sol
:receiveNft
Removes the following storage variables from
BountyStorageCore.sol
:nftDepositLimit
isNFT
Removes the following methods from
BountyCore.sol
:claimNft
_receiveNft
getNftDeposits
Removes the following methods from
TieredBountyCore.sol
:receiveNft
Removes the following methods from
DepositManagerV1.sol
:fundBountyNFT
Modifies the
ClaimManagerV1::claimBounty
andClaimManagerV1::permissionedClaimTieredBounty
to remove the logic that looped over NFT depositsRemoves
ERC721Receiver.sol
import inBountyStorageCore.sol
Removes
if/else
logic inBountyCore
that used to check whether or not the funding is with an NFTupdates all tests to remove nft related tests
updates deploy scripts to deploy without MockNFT.sol
NOTE: I keep the
tokenId
parameter in bounty funding, and also keep the NFT related events though there is no way no to emit them. This is because we don't want to have to make backwards incompatible changes to the current ABIs used across many services