Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): Ignore git-annex remotes marked dead #3147

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Sep 10, 2024

This is a better fix for #3145 - instead of picking a remote by name, test for dead remotes. In the future we might want to consider the other trust levels but this makes it possible to push a git-annex repo where a remote was marked dead at some point without dropping history and get a correct result regardless of remote names.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 44.02%. Comparing base (b4e6f3d) to head (a4cab7f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
services/datalad/datalad_service/common/annex.py 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   44.04%   44.02%   -0.02%     
==========================================
  Files         593      593              
  Lines       37790    37803      +13     
  Branches     1124     1124              
==========================================
+ Hits        16643    16644       +1     
- Misses      20945    20957      +12     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit a80d1ee into master Sep 10, 2024
9 of 10 checks passed
@nellh nellh deleted the dead-repo-support branch September 10, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant