Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): Prefer the s3-PUBLIC remote when found #3146

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Sep 9, 2024

Fixes an issue where the wrong remote was sometimes selected to return a file URL.

See #3145

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.04%. Comparing base (d161827) to head (5622b6f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
services/datalad/datalad_service/common/annex.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3146      +/-   ##
==========================================
- Coverage   44.04%   44.04%   -0.01%     
==========================================
  Files         593      593              
  Lines       37788    37790       +2     
  Branches     1124     1124              
==========================================
  Hits        16644    16644              
- Misses      20942    20944       +2     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit eaf7d50 into master Sep 10, 2024
9 of 10 checks passed
@nellh nellh deleted the remote-preference-fix branch September 10, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant