-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F-477: add nic scheduling attributes #502
Conversation
f168389
to
c07ce4c
Compare
7e613bc
to
83199a0
Compare
If you want to give it a try @jamie-pate here is a first shot, feedback is welcome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is network_id
only required now if network_mode_auto = false
?
(docs need updating)
It seems to work during deployment, but when I re-run terraform it has problems: It looks like the
Deploy works:
This change works:
This change not work
This one also doesn't work
full log
|
Thank you for your feedback.
I'm able to reproduce the error This error is returned by OpenNebula (you can read it in the VM Maybe that we didn't understood how this should be used, in the doc I read: |
@jamie-pate the more I read the more it seems to me that we just can neither attach a new NIC (with |
Could this work if you just record the network_id when you create the resource, then re-use it for modifications? It would need a note in the docs that mention that it only works for VM creation, and the network is fixed on updates unless you select a new network id .. Otherwise it seems like it needs a new feature in opennebula to consider NETWORK_MODE during updates i guess? |
This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days. |
I'll think I'll do minimal change to move forward, I'll add a note on the actual behavior in the VM documentation. If you want something more convenient, for OpenNebula opens an issue here: https://github.com/OpenNebula/one |
83199a0
to
084d12f
Compare
Community Note
Description
Add NIC scheduling attributes
References
Close #477
New or Affected Resource(s)
Checklist
References
go fmt
)