Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-470: fix templates filtering #471

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

treywelsh
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Fix datasource templates filtering: it shouldn't filter on the id attribute

References

Close #470

New or Affected Resource(s)

  • data_opennebula_templates

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@treywelsh treywelsh force-pushed the B-470-fix_templates_filtering branch from 6dfebb6 to 3498a7b Compare July 18, 2023 11:41
@treywelsh treywelsh marked this pull request as ready for review July 18, 2023 12:45
@frousselet frousselet merged commit 4ef251b into master Jul 18, 2023
6 checks passed
@frousselet frousselet deleted the B-470-fix_templates_filtering branch July 18, 2023 14:36
@treywelsh treywelsh mentioned this pull request Aug 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opennebula_templates: name_regex not working
2 participants