Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B-2: Fix optional value update #11

Merged
merged 1 commit into from
Dec 26, 2019
Merged

B-2: Fix optional value update #11

merged 1 commit into from
Dec 26, 2019

Conversation

jaypif
Copy link
Collaborator

@jaypif jaypif commented Dec 24, 2019

Do not display any change if values are optional and not set by user.

Fix #2

@jaypif
B-2: Fix optional value update
68e8f5f 
Do not display any change if values are optional and not set by user.
@ghost ghost added the size/M label Dec 24, 2019
@jaypif jaypif mentioned this pull request Dec 24, 2019
Closed
treywelsh
treywelsh approved these changes Dec 26, 2019
View reviewed changes
Copy link
Collaborator

@treywelsh treywelsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as intended i.e.: when first call to apply is successful, the second call to plan or apply display:
No changes. Infrastructure is up-to-date.

@treywelsh treywelsh merged commit ca21b35 into OpenNebula:master Dec 26, 2019
@jaypif jaypif deleted the B-2 branch June 26, 2020 15:42
@treywelsh treywelsh mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treywelsh treywelsh treywelsh approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform updating in place even when no changes introduced to resource
2 participants
@jaypif @treywelsh