Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSP (and other Servlets) are never destroyed on app change #502

Closed
jesse-gallagher opened this issue Dec 11, 2023 · 0 comments
Closed

JSP (and other Servlets) are never destroyed on app change #502

jesse-gallagher opened this issue Dec 11, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
2.15.0

Comments

@jesse-gallagher
Copy link
Member

The destroy() method on Servlets created by the IServletFactory implementations is currently never called, which leaves resources open. In the case of JSP specifically, there is global state that is added to each time a JspServlet is initialized, and this is never reclaimed.
@jesse-gallagher jesse-gallagher added the bug Something isn't working label Dec 11, 2023
@jesse-gallagher jesse-gallagher added this to the 2.15.0 milestone Dec 11, 2023
jesse-gallagher added a commit that referenced this issue Dec 11, 2023
@jesse-gallagher
Modify MappingBasedServletFactory to keep a static cache of Servlets …
897cfdc 
…and to destroy them as needed (Issue #502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.15.0
Development

No branches or pull requests
1 participant
@jesse-gallagher