Mark MultiInputter as built when all children are built (#421)

OpenNMT · Apr 29, 2019 · fd0a7f6 · fd0a7f6
1 parent 0383fea
commit fd0a7f6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ OpenNMT-tf follows [semantic versioning 2.0.0](https://semver.org/). The API cov
 ### Fixes and improvements
 
 * Fix usage of `--checkpoint_path` during training
+* Fix embedding sharing with a `ParallelInputter` as input
 
 ## [1.22.0](https://github.com/OpenNMT/OpenNMT-tf/releases/tag/v1.22.0) (2019-04-06)
 

diff --git a/opennmt/inputters/inputter.py b/opennmt/inputters/inputter.py
@@ -302,6 +302,12 @@ def get_leaf_inputters(self):
         inputters.append(inputter)
     return inputters
 
+  def __getattribute__(self, name):
+    if name == "built":
+      return all(inputter.built for inputter in self.inputters)
+    else:
+      return super(MultiInputter, self).__getattribute__(name)
+
   def initialize(self, metadata, asset_dir=None, asset_prefix=""):
     for i, inputter in enumerate(self.inputters):
       inputter.initialize(metadata, asset_prefix="%s%d_" % (asset_prefix, i + 1))