Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manylinux tag #52

Merged
merged 7 commits into from
Oct 13, 2021
Merged

Remove manylinux tag #52

merged 7 commits into from
Oct 13, 2021

Conversation

nph4rd
Copy link
Member

@nph4rd nph4rd commented Oct 5, 2021

Description

This change will allow us to publish the package within a docker container.

Affected Dependencies

How has this been tested?

Tested locally.

Checklist

@nph4rd nph4rd added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Oct 5, 2021
@nph4rd nph4rd self-assigned this Oct 5, 2021
@nph4rd nph4rd requested a review from tholop October 5, 2021 15:33
@tholop
Copy link
Member

tholop commented Oct 5, 2021

Thanks! Let's find a way to test the release packages without spamming PyPI (e.g. https://test.pypi.org/) and document it for future uses.

@nph4rd
Copy link
Member Author

nph4rd commented Oct 13, 2021

Thanks! Let's find a way to test the release packages without spamming PyPI (e.g. https://test.pypi.org/) and document it for future uses.

Hey @tholop - tried to use TestPyPI but did not succeed. Specifically, it wasn't clear to me how to use manylinux2014 for publishing. I was trying something like this, but no luck:

docker run --rm -v $(pwd):/io konstin2/maturin publish -b cffi --no-sdist -r https://test.pypi.org/legacy/ -u USERNAME -p PASSWORD --skip-auditwheel --manylinux 2014

I think the problem was due to this:

Invalid value for project_urls. Error: Use both a label and an URL.

However, I never managed to upload anything, even after playing around with the project-url config in Cargo.toml (see
e8c6171 for the config I used).

Any ideas?

@nph4rd
Copy link
Member Author

nph4rd commented Oct 13, 2021

Opened this issue, as I believe the problem is not due to the config.

@nph4rd
Copy link
Member Author

nph4rd commented Oct 13, 2021

Opened this issue, as I believe the problem is not due to the config.

Managed to publish with:

docker run --rm -v $(pwd):/io konstin2/maturin publish -b cffi --no-sdist -r https://test.pypi.org/legacy/ -u USERNAME -p PASSWORD --manylinux 2014

As was suggested here, we might want to use a GH Actions workflow to compile the wheel that we're interested in.

@nph4rd
Copy link
Member Author

nph4rd commented Oct 13, 2021

Update: Managed to build and publish package for aarch architecture as follows:

  1. Run docker container with:
docker run --rm -it -v $(pwd):/home/rust/src messense/manylinux_2_24-cross:aarch64
  1. Downloaded Rust tools via Rustup:
curl https://sh.rustup.rs -sSf | bash -s -- -y
  1. Configured shell:
echo 'source $HOME/.cargo/env' >> $HOME/.bashrc
source $HOME/.cargo/env
  1. Added target:
rustup target add aarch64-unknown-linux-gnu
  1. Publish package:
maturin publish -b cffi --no-sdist -r https://test.pypi.org/legacy/ -u USER -p PASSWORD --manylinux 2014

I think we can just modify the docker image so as to run the last command in a GH Actions workflow. WDYT?

@nph4rd nph4rd changed the title Update manylinux 2010 -> 2014 Remove manylinux tag Oct 13, 2021
@nph4rd nph4rd merged commit b237400 into OpenMined:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants