Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for pip install ring app requirement #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shubham3121
Copy link
Member

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@shubham3121 shubham3121 marked this pull request as draft October 21, 2024 11:06
@shubham3121 shubham3121 removed the request for review from IonesioJunior October 21, 2024 11:06
@shubham3121 shubham3121 changed the title install pip for the python version installed by pip Fix path for pip install Oct 21, 2024
@shubham3121 shubham3121 changed the title Fix path for pip install Fix path for pip install ring app requirement Oct 21, 2024
@shubham3121 shubham3121 marked this pull request as ready for review October 21, 2024 12:22
Copy link
Contributor

@yashgorana yashgorana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks local dev + does not install package in uv's venv

image

with this pr - uses standard pip
image

on the main branch - uses uv's pip resolver
image

Copy link
Contributor

@yashgorana yashgorana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's understand what this change entails. if it works on local dev, but breaks in subprocess open - let's understand the difference in the env vars between shell exec and subprocess.

@snwagh
Copy link
Collaborator

snwagh commented Oct 21, 2024

For logging since Andrew wanted simple scripts, I have moved the logging into the App logic (for instance here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants