Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance for the Raw container #162

Merged
merged 16 commits into from
Feb 17, 2023

Conversation

s0l0ist
Copy link
Contributor

@s0l0ist s0l0ist commented Feb 17, 2023

Description

Feat:

  • The complexity of the underlying Raw intersection computation has improved
    from O(nmlog(m)) -> O(nlog(n) + max(n, m)); however, internal protobuf
    deserialization remains as the dominant performance inhibitor for the
    client->GetIntersection* methods.

Fix:

  • The go integration tests were not using the datastructure param properly.
    The fix did not result in any regression.

Chore:

  • Update C++ benchmarks to include the new Raw enum variant
  • Misc fixes to tests which were not rounding correctly and causing CI to fail
    randomly
  • Update the main README to include a description of the protocol

Affected Dependencies

N/A

How has this been tested?

  • CI

Checklist

@s0l0ist s0l0ist added Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase labels Feb 17, 2023
@s0l0ist s0l0ist marked this pull request as ready for review February 17, 2023 16:58
@s0l0ist s0l0ist merged commit 20952d9 into master Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the nangelou-improve-raw-performance branch February 17, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant