-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved performance for the Raw
container
#162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0l0ist
added
Type: Documentation 📚
Improvements or additions in documentation for some file, feature, or codebase
Type: Improvement 📈
Performance improvement not introducing a new feature or requiring a major refactor
Type: Refactor 🔨
A complete overhaul of a file, feature, or codebase
Type: Testing 🧪
Add testing or improving existing testing of a file, feature, or codebase
labels
Feb 17, 2023
delete-merged-branch
bot
deleted the
nangelou-improve-raw-performance
branch
February 17, 2023 16:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Documentation 📚
Improvements or additions in documentation for some file, feature, or codebase
Type: Improvement 📈
Performance improvement not introducing a new feature or requiring a major refactor
Type: Refactor 🔨
A complete overhaul of a file, feature, or codebase
Type: Testing 🧪
Add testing or improving existing testing of a file, feature, or codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feat:
Raw
intersection computation has improvedfrom
O(nmlog(m))
->O(nlog(n) + max(n, m))
; however, internal protobufdeserialization remains as the dominant performance inhibitor for the
client->GetIntersection*
methods.Fix:
go
integration tests were not using the datastructure param properly.The fix did not result in any regression.
Chore:
C++
benchmarks to include the newRaw
enum variantrandomly
Affected Dependencies
N/A
How has this been tested?
Checklist