-
Notifications
You must be signed in to change notification settings - Fork 549
Conversation
👍 Ping @LeeSaferite |
I'll get to this after work today. |
Ok, I've had time to check this now so I'll merge. Thanks! |
Import Magento Release 1.9.2.1
No problem @LeeSaferite, thanks for merging. Your repo has helped me out in the past, glad to be able to contribute. |
@ToonSpin: Can you provide reference of the filename of the package you created this PR from including checksums of the file? |
I can provide them in the morning. I personally grabbed the release file from Magento and did the import again just to do a compare as I don't know @ToonSpin at all. According to git the two were identical. In the future I'll start adding the filename and fingerprint of the file used to do the import. If anyone has any suggestions for more information that should be included, feel free to comment. |
I can certainly see where @ktomk is coming from, and if I were @LeeSaferite (who indeed does not know me at all) I would have done the exact same thing. Let me provide a short walkthrough of how I created the commit: On my Ubuntu box I downloaded Magento 1.9.2.1, file name was
The next steps:
You should get an identical commit to mine if you follow the above steps, but note that the commit hash will be different, because among other things, you have a different name and e-mail address. |
@ktomk there is a way to verify that the above yields the exact same files as what I did. Run
Where COMMIT is the commit you want to inspect. Try this on two different commits, and if the hashes match, then all of the files in the entire commits are exactly the same. |
@ToonSpin: Thanks for all the clarifications you've made and I'm sorry I wasn't equally differentiated when asking for feedback: I was concerned about the filename (when I download from that Magento vendor website I get filenames like This is what I get from a current download: The currently given file behind Cookie-Login is:
How did I do it? Here is a short line-up of commands and their parameters used. Download was by hand from the vendors website.
For the previous release we started to track these in the magerun repo as it has a magento installer feature, see for references here: netz98/n98-magerun#609 Despite Magento is marketed with version numbers (like 1.9.2.0), it indeed does timestamp versioned releases. It think it is a good idea to make visible which release has been mirrored by having that meta-data (the timestamp and checksums of the package) with the commit. I already asked for 1.9.2.0 here. For the files itself (not the package), it's possible to reverse engineer for which the git commands you presented are useful. But it's a bit burdensome for documentation purposes to find out afterwards. |
No description provided.