Fix: InvalidParamTypeProvidedNULL: fixed login() method

[eneiasramos]

Description (*)

I got an error using API when applying the last commits to my master branch.

Apparently any API call is generating the error: Invalid param type provided ("null")

Applying the fix the error disappears.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[kiatng]

I have this commit 41ea3c6 in production, which uses JSON-RPC with basic auth with requests daily, so far nothing bad is reported.

[eneiasramos]

@kiatng

Another consideration to do is that apiKey parameter can be null ( apiKey = null ).
However the invalid_request_param fault is triggered in this case.

if (empty($username) || empty($apiKey)) {
            $this->_fault('invalid_request_param');
            return;
        }

So it doesn't make sense that apiKey could be null at this point :)

[sreichel]

Another consideration to do is that apiKey parameter can be null ( apiKey = null ).
However the invalid_request_param fault is triggered in this case.

We should not change methods parameters. Default null does not do anything. Removing it should not change you problem.

[eneiasramos]

@sreichel

Actually the change solved the problem :)

gamuzatech@afec611

[sreichel]

@eneiasramos i dont see how doc type should have impact on it ... please check.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[eneiasramos]

@sreichel

Sorry for the delay in responding.

The adjustment worked as expected.

Thank you very much for your support :)

[sreichel]

Thanks for reporting & PR :)