Fix for catalog_product_relation not being deleted when bundle option deleted. #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can replicate this in DDEV with sample product ID 447 and monitoring the table When a child product is deleted, the product needs to save twice for the table to be refreshed. With this PR, the table is refreshed on product save. |
|
Sorry for accidentally closing the PR. @dannydnz Is your change in production, have you tested it and is satisfied that it has no side-effect? |
|
Testing it, but please upgrade the description/title. Only your branch name tells its about bundle items. |
dannydnz
changed the title
|
Have updated PR title. Yes is in production. No issues so far. |
kiatng
approved these changes
Nov 29, 2024
|
@all-contributors please add @dannydnz for code |
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Nov 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Patch for when a Bundle option or selection is deleted. Previously product would have to be saved twice to remove the catalog_product_relation row. This messes with some indexes.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)