Fix validateHttpVersion to be RFC 1945 and RFC 7230 compliant #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: lib/Mage
|
What does "." mean @sreichel |
|
@leissbua was a comment on your first commit. The change you have reverted, |
kiatng
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Ref https://www.rfc-editor.org/rfc/rfc7230#section-3.1.2:
The reason-phrase element exists for the sole purpose of providing a textual description associated with the numeric status code, mostly out of deference to earlier Internet application protocols that were more frequently used with interactive text clients. A client SHOULD ignore the reason-phrase content.
|
Thanks for that info. |
sreichel
approved these changes
Nov 24, 2024
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Mage_HTTP_Client_Curlis expecting the HTTP Response Header to have 3 elements.However, the Reason-Phrase is optional, e.g. Apple Pay does not return OK Reason-Phrase on the current
validationURL()endpoint which is HTTP 1.1. I fixed the code to allow 2 or 3 elements as it does for HTTP 2.0 in the current version