-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary PHP 8.4 support: Fixed implicitly nullable parameter deprecation warning #4037
Conversation
isn't modifying public method a breaking change? |
I did not look through all of them yet, but if it only makes existing parameters nullable, which already use Null as default value, thats not likely to break anything. |
but if they were overridden by some 3rd party code, the method signature changes and the user would get a warning/error no? |
seems to be fine mixed up the order |
ok I've also done some tests and the core of this PR is ok, but it has too much stuff, it adds rector and polifys that are not related to the PR itself, so I will remove those parts and only keep the "inplicitly nullable" part |
See https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated