-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP8.2 is now the minimum version for v21 #3920
Conversation
Even this PR benefits from approvals, the PHPStan error must be fixed before merging. Related to this change, in production I use Debian 10, 11, 12 servers that have LTS's for PHP versions 7.3, 7.4, 8.2. For the first two I will benefit from support even after the period ends. Increasing the minimum requirement must be done with caution. I recently had to deal with a store where I started from PHP 7.0 perfectly functional. Moving it to 8.2 was crazy, so I left it on 7.4 for a while until I evaluate how long a complete migration will take. |
@addison74 phpstan errors comes from version 66 and will be fixed when #3880 gets merged, which by the way I should merge anyway. phpstan 66 is in this PR because I had to run a full composer install since the requirements are changed (removed the polyfills) |
I'll merge since it's approved and all checks are green |
v21 will have to be released sometimes (I hope very soon) but there's no point in releasing it in a few months supporting a PHP version that's already out of the active support.
Also, 8.1-8.2 don't have a lot of differences so, for people that need to upgrade to 8.1, it doesn't take a bigger effort to upgrade to 8.2.
Also, this PR allows for removing some of the polyfills we needed, making the final installation size smaller.
Side benefit, with this PR, PHPStan has to check 3800 files instead of 4300