-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Autolabeler Config to Version 5.0.0 #3695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Since you're contributing at least on a semi-regular basis to open mage: do you want to take the opportunity to add you to the contributors?
(Just a thought, I don't know if there are rules for this and if you really want to 😅)
@tobihille I always assumed I've added myself already. Doesn't seem like it though. |
@Sdfendor should it be this way? |
@fballiano This is the old state, the current run - as it is my understanding - uses the main autolabeler config not the one from PR (so in this PR the error is still visible). So only after this is merged new/existing PRs will start using the new config in autolabeler runs. |
I've tested locally with [Labeler/Add labels] ❗ ::error::Error: found unexpected type for label 'Environment' (should be array of config options) |
I don't understand why it says that it can't find the labeler.yml when it's there... anyway, i'm not opposed to merging this one and see what happens |
I'm also not sure why this is the case. We encountered the same behavior on our current shop repo here on Github though. After merge it started to label once again. We made the same kind of adjustments (just less of them) that are present in this PR to our labeler.yml. |
since the current state of the main branch is broken anyway, and we already use "pull_request" as trigger (as people are talking about in actions/labeler#712) I think we should merge this one and see what happens, I can't be worse than the actual state. |
This reverts commit 07812cc.
I think we should merge this and see if it works on the other PRs |
it's merged and I run it on #3707 but I think it still doesn't work what should we do? |
In which way didn't it work? I can't see an error in the run in #3707 which was the main goal of this PR. The "fetching via the api" info line has been there before and is still there. |
ah! sorry but when I ran it it didn't seem to have added the javascript label, which it's actually added.. maybe I didn't see it at that time for some reason 😅 it's solved then, thank you! |
Description (*)
Github Autolabeler updated to version 5.0.0 three days ago which breaks existing configuration files.
This PR adjusts the config so that it works again. No other changes regarding e.g. orphaned entries or new capabilities of new version of Autolabeler are part of this PR.
Contribution checklist (*)