Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix Clang warnings about hidden virtual methods #2222

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Attempt to fix Clang warnings about hidden virtual methods #2222

merged 1 commit into from
Mar 7, 2019

Conversation

akortunov
Copy link
Collaborator

Let see if it will help us.

@akortunov akortunov changed the title Attemp to fix Clang warnings about hidden virtual methods Attempt to fix Clang warnings about hidden virtual methods Mar 7, 2019
@kcat
Copy link
Contributor

kcat commented Mar 7, 2019

Personally I'd suggest adding override instead of virtual, for the virtual overrides. That'll ensure properly matching prototypes, and not inadvertently create unneeded virtuals.

@psi29a psi29a merged commit a381a1a into OpenMW:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akortunov @kcat @psi29a