Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart voucher reservation feature #5

Closed
starkmsu opened this issue Apr 20, 2020 · 2 comments
Closed

Smart voucher reservation feature #5

starkmsu opened this issue Apr 20, 2020 · 2 comments
Assignees
@starkmsu @ofmaska

Comments

@starkmsu
Copy link
Member

starkmsu commented Apr 20, 2020 •
edited
Loading

  1. Expose endpoints for smart voucher reservation and reservation cancellation
    a) for voucher reservation - replace BuyVoucherAsync with ReserveVoucherAsync
    b) for voucher reservation cancellation - add CancelVoucherReservationAsync(string shortCode)

  2. Implement exposed endpoints

Implementation details:
Preserve existing buy voucher logic - it would be used in #6
@starkmsu starkmsu changed the title Endpoint for smart voucher reservation Smart voucher reservation feature Apr 20, 2020
@ElenaBelyavskaya ElenaBelyavskaya mentioned this issue Apr 21, 2020
Closed
@ofmaska
Copy link
Contributor

ofmaska commented Apr 22, 2020

++

starkmsu added a commit that referenced this issue Apr 28, 2020
@starkmsu
Merge pull request #7 from ofmaska/master
8a95268 
Smart voucher reservation feature #5
@starkmsu starkmsu self-assigned this Apr 28, 2020
@starkmsu
Copy link
Member Author

Updated service is deployed to internal environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@starkmsu starkmsu

@ofmaska ofmaska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@starkmsu @ofmaska