Merge pull request #57 from IliyanIlievPH/56

Closes #56

client/MAVN.Service.SmartVouchers.Client/Models/Responses/Enums/TransferVoucherErrorCodes.cs

@@ -11,7 +11,11 @@ public enum TransferVoucherErrorCodes
         VoucherNotFound,
         /// <summary>Not an owner</summary>
         NotAnOwner,
-        /// <summary>Voucher is already used</summary>
-        VoucherIsUsed,
+        /// <summary>Voucher cannot be transferred because it is not in a correct state</summary>
+        VoucherIsNotInTheCorrectStateToTransfer,
+        /// <summary>
+        /// Campaign is missing for smart voucher
+        /// </summary>
+        VoucherCampaignNotFound,
     }
 }

contract/MAVN.Service.SmartVouchers.Contract/SmartVoucherTransferredEvent.cs

@@ -0,0 +1,47 @@
+using System;
+
+namespace MAVN.Service.SmartVouchers.Contract
+{
+    public class SmartVoucherTransferredEvent
+    {
+        /// <summary>
+        /// Timestamp
+        /// </summary>
+        public DateTime Timestamp { get; set; }
+
+        /// <summary>
+        /// Customer id of the sender
+        /// </summary>
+        public Guid OldCustomerId { get; set; }
+
+        /// <summary>
+        /// Customer id of the receiver
+        /// </summary> 
+        public Guid NewCustomerId { get; set; }
+
+        /// <summary>
+        /// Partner id
+        /// </summary>
+        public Guid PartnerId { get; set; }
+
+        /// <summary>
+        /// Id of the smart voucher campaign
+        /// </summary>
+        public Guid CampaignId { get; set; }
+
+        /// <summary>
+        /// Short code of the voucher
+        /// </summary>
+        public string VoucherShortCode { get; set; }
+
+        /// <summary>
+        /// Amount
+        /// </summary>
+        public decimal Amount { get; set; }
+
+        /// <summary>
+        /// Currency
+        /// </summary>
+        public string Currency { get; set; }
+    }
+}

src/MAVN.Job.SmartVouchers/Modules/RabbitMqModule.cs

@@ -16,6 +16,7 @@ public class RabbitMqModule : Module
     {
         private const string PubVoucherSoldExchangeName = "lykke.smart-vouchers.vouchersold";
         private const string PubVoucherUsedExchangeName = "lykke.smart-vouchers.voucherused";
+        private const string PubVoucherTransferredExchangeName = "lykke.smart-vouchers.vouchertransferred";
         private const string SubExchangeName = "lykke.payment.completed"; // TODO pass proper exchange name
 
         private readonly RabbitMqSettings _settings;
@@ -43,6 +44,9 @@ private void RegisterRabbitMqPublishers(ContainerBuilder builder)
             builder.RegisterJsonRabbitPublisher<SmartVoucherUsedEvent>(
                 _settings.Publishers.ConnectionString,
                 PubVoucherUsedExchangeName);
+            builder.RegisterJsonRabbitPublisher<SmartVoucherTransferredEvent>(
+                _settings.Publishers.ConnectionString,
+                PubVoucherTransferredExchangeName);
         }
 
         private void RegisterRabbitMqSubscribers(ContainerBuilder builder)

src/MAVN.Service.SmartVouchers.Domain/Enums/TransferVoucherError.cs

@@ -5,6 +5,7 @@ public enum TransferVoucherError
         None,
         VoucherNotFound,
         NotAnOwner,
-        VoucherIsUsed,
+        VoucherIsNotInTheCorrectStateToTransfer,
+        VoucherCampaignNotFound,
     }
 }

src/MAVN.Service.SmartVouchers.DomainServices/VouchersService.cs

@@ -32,6 +32,7 @@ public class VouchersService : IVouchersService
         private readonly IRedisLocksService _redisLocksService;
         private readonly IRabbitPublisher<SmartVoucherSoldEvent> _voucherSoldPublisher;
         private readonly IRabbitPublisher<SmartVoucherUsedEvent> _voucherUsedPublisher;
+        private readonly IRabbitPublisher<SmartVoucherTransferredEvent> _voucherTransferredPublisher;
         private readonly ILog _log;
         private readonly TimeSpan _lockTimeOut;
 
@@ -45,6 +46,7 @@ public VouchersService(
             IRedisLocksService redisLocksService,
             IRabbitPublisher<SmartVoucherSoldEvent> voucherSoldPublisher,
             IRabbitPublisher<SmartVoucherUsedEvent> voucherUsedPublisher,
+            IRabbitPublisher<SmartVoucherTransferredEvent> voucherTransferredPublisher,
             TimeSpan lockTimeOut)
         {
             _paymentManagementClient = paymentManagementClient;
@@ -57,6 +59,7 @@ public VouchersService(
             _log = logFactory.CreateLog(this);
             _lockTimeOut = lockTimeOut;
             _voucherUsedPublisher = voucherUsedPublisher;
+            _voucherTransferredPublisher = voucherTransferredPublisher;
         }
 
         public async Task<ProcessingVoucherError> ProcessPaymentRequestAsync(Guid paymentRequestId)
@@ -290,15 +293,21 @@ public async Task<TransferVoucherError> TransferVoucherAsync(
             if (voucher == null)
                 return TransferVoucherError.VoucherNotFound;
 
-            if (voucher.Status != VoucherStatus.InStock)
-                return TransferVoucherError.VoucherIsUsed;
+            if (voucher.Status != VoucherStatus.Sold)
+                return TransferVoucherError.VoucherIsNotInTheCorrectStateToTransfer;
+
             if (voucher.OwnerId != oldOwnerId)
                 return TransferVoucherError.NotAnOwner;
 
+            var campaign = await _campaignsRepository.GetByIdAsync(voucher.CampaignId, false);
+            if (campaign == null)
+                return TransferVoucherError.VoucherCampaignNotFound;
+
             voucher.OwnerId = newOwnerId;
             var validationCode = GenerateValidation();
 
             await _vouchersRepository.UpdateAsync(voucher, validationCode);
+            await PublishVoucherTransferredEvent(campaign, voucher, oldOwnerId);
 
             return TransferVoucherError.None;
         }
@@ -415,6 +424,21 @@ await _voucherUsedPublisher.PublishAsync(new SmartVoucherUsedEvent
             });
         }
 
+        private async Task PublishVoucherTransferredEvent(VoucherCampaign voucherCampaign, Voucher voucher, Guid oldOwnerId)
+        {
+            await _voucherTransferredPublisher.PublishAsync(new SmartVoucherTransferredEvent
+            {
+                Amount = voucherCampaign.VoucherPrice,
+                Currency = voucherCampaign.Currency,
+                PartnerId = voucherCampaign.PartnerId,
+                Timestamp = DateTime.UtcNow,
+                CampaignId = voucher.CampaignId,
+                VoucherShortCode = voucher.ShortCode,
+                NewCustomerId = voucher.OwnerId.Value,
+                OldCustomerId = oldOwnerId,
+            });
+        }
+
         private static string GenerateValidation()
         {
             var bytes = Encoding.ASCII.GetBytes(Guid.NewGuid().ToString());

src/MAVN.Service.SmartVouchers/Modules/RabbitMqModule.cs

@@ -15,6 +15,7 @@ public class RabbitMqModule : Module
     {
         private const string PubVoucherSoldExchangeName = "lykke.smart-vouchers.vouchersold";
         private const string PubVoucherUsedExchangeName = "lykke.smart-vouchers.voucherused";
+        private const string PubVoucherTransferredExchangeName = "lykke.smart-vouchers.vouchertransferred";
         private const string SubExchangeName = "lykke.payment.completed"; // TODO pass proper exchange name
 
         private readonly RabbitMqSettings _settings;
@@ -42,6 +43,9 @@ private void RegisterRabbitMqPublishers(ContainerBuilder builder)
             builder.RegisterJsonRabbitPublisher<SmartVoucherUsedEvent>(
                 _settings.Publishers.ConnectionString,
                 PubVoucherUsedExchangeName);
+            builder.RegisterJsonRabbitPublisher<SmartVoucherTransferredEvent>(
+                _settings.Publishers.ConnectionString,
+                PubVoucherTransferredExchangeName);
         }
 
         private void RegisterRabbitMqSubscribers(ContainerBuilder builder)