Added errors processing for payment generation call

OpenMAVN · Apr 29, 2020 · 5d4be4e · 5d4be4e
1 parent ec14471
commit 5d4be4e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/...t/MAVN.Service.SmartVouchers.Client/Models/Responses/Enums/ProcessingVoucherErrorCodes.cs b/...t/MAVN.Service.SmartVouchers.Client/Models/Responses/Enums/ProcessingVoucherErrorCodes.cs
@@ -15,5 +15,7 @@ public enum ProcessingVoucherErrorCodes
         NoAvailableVouchers,
         /// <summary>Voucher not found</summary>
         VoucherNotFound,
+        /// <summary>Invalid partner payment configuration</summary>
+        InvalidPartnerPaymentConfiguration,
     }
 }
diff --git a/src/MAVN.Service.SmartVouchers.Domain/Enums/ProcessingVoucherError.cs b/src/MAVN.Service.SmartVouchers.Domain/Enums/ProcessingVoucherError.cs
@@ -7,5 +7,6 @@ public enum ProcessingVoucherError
         VoucherCampaignNotActive,
         NoAvailableVouchers,
         VoucherNotFound,
+        InvalidPartnerPaymentConfiguration,
     }
 }
diff --git a/...AVN.Service.SmartVouchers.DomainServices/MAVN.Service.SmartVouchers.DomainServices.csproj b/...AVN.Service.SmartVouchers.DomainServices/MAVN.Service.SmartVouchers.DomainServices.csproj
@@ -6,7 +6,7 @@
   <ItemGroup>
     <PackageReference Include="AutoMapper" Version="9.0.0" />
     <PackageReference Include="Lykke.RabbitMqBroker" Version="7.13.1" />
-    <PackageReference Include="MAVN.Service.PaymentManagement.Client" Version="1.9.0" />
+    <PackageReference Include="MAVN.Service.PaymentManagement.Client" Version="1.10.1" />
     <PackageReference Include="StackExchange.Redis" Version="2.1.30" />
   </ItemGroup>
   <ItemGroup>

diff --git a/src/MAVN.Service.SmartVouchers.DomainServices/VouchersService.cs b/src/MAVN.Service.SmartVouchers.DomainServices/VouchersService.cs
@@ -7,6 +7,7 @@
 using Lykke.Common.Log;
 using MAVN.Service.PaymentManagement.Client;
 using MAVN.Service.PaymentManagement.Client.Models.Requests;
+using MAVN.Service.PaymentManagement.Client.Models.Responses;
 using MAVN.Service.SmartVouchers.Domain.Enums;
 using MAVN.Service.SmartVouchers.Domain.Models;
 using MAVN.Service.SmartVouchers.Domain.Repositories;
@@ -136,6 +137,14 @@ public async Task<VoucherReservationResult> ReserveVoucherAsync(Guid voucherCamp
                         Currency = campaign.Currency,
                         PartnerId = campaign.PartnerId,
                     });
+                if (paymentRequestResult.ErrorCode != PaymentGenerationErrorCode.Success)
+                {
+                    await CancelReservationAsync(voucher.ShortCode);
+                    return new VoucherReservationResult
+                    {
+                        ErrorCode = ProcessingVoucherError.InvalidPartnerPaymentConfiguration,
+                    };
+                }
 
                 await _paymentRequestsRepository.CreatePaymentRequestAsync(paymentRequestResult.PaymentRequestId, voucher.ShortCode);