automate plugin versions displayed. #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaneethsnair1
force-pushed
the
mavenGradle
branch
from
124cf63
to
b84369a
Compare
natalie-bernhard
force-pushed
the
mavenGradle
branch
from
b84369a
to
b4e90b5
Compare
natalie-bernhard
requested changes
May 16, 2024
There was a problem hiding this comment.
Code looks overall great! In start.html, can you just add in the current latest Maven plugin (3.10.3) and Gradle plugin (3.8.3) versions back as the default text in the code blocks to act as placeholders, just in case the API request fails for any reason. This will help prevent users from copying an unusable code snippet. Instead, it may be outdated but should still work even if the version is not completely up to date.
navaneethsnair1
force-pushed
the
mavenGradle
branch
from
b4e90b5
to
0c762c3
Compare
natalie-bernhard
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed and why?
As requested, code from start.openliberty.io is migrated to ol repo.
Tested using browser:
Did you test accessibility: