Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta guard from telemetry SPI #30032

Open
wants to merge 3 commits into
base: integration
Choose a base branch
from

Conversation

benjamin-confino
Copy link
Member

@benjamin-confino benjamin-confino commented Nov 1, 2024

Associated with epic: https://github.ibm.com/websphere/WS-CD-Open/issues/32050

@benjamin-confino benjamin-confino changed the title Ws32050 remove beta Remove beta guard from telemetry SPI Nov 1, 2024
@@ -42,11 +42,10 @@ public class OpenTelemetryAccessor {
* is disabled or the application has shut down.
*/
public static OpenTelemetryInfoInternal getOpenTelemetryInfo() {
//TOOD when the SPI is out of beta, make this a redirect to the SPI accessor to avoid code duplication
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this inverted, as most calls will come through this class so redirecting into it saves one more hop for the most used path.

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Nov 1, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=45a9774f-f6e2-4949-8504-792580e618b6

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 1, 2024

@LibbyBot
Copy link

LibbyBot commented Nov 1, 2024

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

LibbyBot commented Nov 1, 2024

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Nov 1, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LyMlQJibEe-M9e5esDPP_g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 2, 2024

The build benjamin-confino-30032-20241101-1559
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LyMlQJibEe-M9e5esDPP_g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_LyMlQJibEe-M9e5esDPP_g

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Nov 3, 2024

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Nov 3, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_uPLNIJoXEe-M9e5esDPP_g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 3, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=dadc614b-7db8-4666-bd2f-a185c4408eba

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 4, 2024

@LibbyBot
Copy link

LibbyBot commented Nov 4, 2024

The build benjamin-confino-30032-20241103-1221
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_uPLNIJoXEe-M9e5esDPP_g
completed successfully!

Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this PR look ok, but we can't consider merging it at the moment because the related tests are only testing against mpTelemetry-2.0 and not 1.0 or 1.1.

@benjamin-confino
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Nov 5, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=dc333f3a-4e80-4e2d-82fd-21d3f20b792d

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 5, 2024

@LibbyBot
Copy link

LibbyBot commented Nov 6, 2024

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Nov 6, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_D9zCgJvVEe-M9e5esDPP_g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Nov 6, 2024

The build benjamin-confino-30032-20241106-0131
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_D9zCgJvVEe-M9e5esDPP_g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_D9zCgJvVEe-M9e5esDPP_g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants