-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beta guard from telemetry SPI #30032
base: integration
Are you sure you want to change the base?
Remove beta guard from telemetry SPI #30032
Conversation
@@ -42,11 +42,10 @@ public class OpenTelemetryAccessor { | |||
* is disabled or the application has shut down. | |||
*/ | |||
public static OpenTelemetryInfoInternal getOpenTelemetryInfo() { | |||
//TOOD when the SPI is out of beta, make this a redirect to the SPI accessor to avoid code duplication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this inverted, as most calls will come through this class so redirecting into it saves one more hop for the most used path.
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=45a9774f-f6e2-4949-8504-792580e618b6 Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_LyMlQJibEe-M9e5esDPP_g Target locations of links might be accessible only to IBM employees. |
The build benjamin-confino-30032-20241101-1559 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_LyMlQJibEe-M9e5esDPP_g |
859120c
to
90cf9d2
Compare
#build |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_uPLNIJoXEe-M9e5esDPP_g Target locations of links might be accessible only to IBM employees. |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=dadc614b-7db8-4666-bd2f-a185c4408eba Target locations of links might be accessible only to IBM employees. |
The build benjamin-confino-30032-20241103-1221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this PR look ok, but we can't consider merging it at the moment because the related tests are only testing against mpTelemetry-2.0
and not 1.0
or 1.1
.
#build |
Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=dc333f3a-4e80-4e2d-82fd-21d3f20b792d Target locations of links might be accessible only to IBM employees. |
Please code review feature-related files, @OpenLiberty/delivery-approvers |
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_D9zCgJvVEe-M9e5esDPP_g Target locations of links might be accessible only to IBM employees. |
The build benjamin-confino-30032-20241106-0131 For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_D9zCgJvVEe-M9e5esDPP_g |
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Associated with epic: https://github.ibm.com/websphere/WS-CD-Open/issues/32050