Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jakartaee build integration #11177

Closed

Conversation

cbridgha
Copy link
Member

@cbridgha cbridgha commented Mar 4, 2020

Initial push of Jakarta transform integrated with build on the webcontainer / servlet -5 feature

@LibbyBot
Copy link

LibbyBot commented Mar 4, 2020

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 43 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 11 infrastructure code files were changed.

  • 15 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_ko.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_ru.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_es.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_zh.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_ja.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_it.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_zh_TW.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_ro.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_pl.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_hu.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_de.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_cs.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_pt_BR.properties

  • dev/com.ibm.websphere.appserver.features/visibility/public/servlet-5.0/resources/l10n/com.ibm.websphere.appserver.servlet-5.0_fr.properties

@cbridgha
Copy link
Member Author

cbridgha commented Mar 4, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Mar 4, 2020

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Mar 4, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_jH9-0F4oEeqLhL9ibUVjEA

Target locations of links might be accessible only to IBM employees.

@cbridgha
Copy link
Member Author

cbridgha commented Mar 4, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Mar 4, 2020

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Mar 4, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_BWX2UF5ZEeqLhL9ibUVjEA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

The build cbridgha-11177-20200304-2235
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_BWX2UF5ZEeqLhL9ibUVjEA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_BWX2UF5ZEeqLhL9ibUVjEA

@cbridgha
Copy link
Member Author

cbridgha commented Mar 5, 2020

#build

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

Please code review feature-related files, @OpenLiberty/delivery-approvers

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_AmUzQF52EeqLhL9ibUVjEA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

@LibbyBot
Copy link

LibbyBot commented Mar 5, 2020

The build cbridgha-11177-20200305-0245
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_AmUzQF52EeqLhL9ibUVjEA
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_AmUzQF52EeqLhL9ibUVjEA

@andrea-pichler
Copy link

No message review requested from L2

com.ibm.ws:jakartaee-transformer:0.0.2
biz.aQute.bnd:biz.aQute.bndlib:4.3.1
commons-cli:commons-cli:1.4
org.slf4j:slf4j-simple:1.7.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is supposed to be in alphabetical order

#NLS_MESSAGEFORMAT_NONE
#

description=This feature enables support for HTTP Servlets written to the Java Servlet 4.0 specification. \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be easy to forget to change this version number later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants