-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous integration of the Red Hat LSP4iJ plug-in #840
Continuous integration of the Red Hat LSP4iJ plug-in #840
Conversation
- Set up a cron job to run every midnight. - Fetch and checkout sha of each opened PR in lsp4ij and run LTI builds. - Parameterize LTI Build
Tested Workflow using local lsp4ij - https://github.com/anusreelakshmi934/liberty-tools-intellij/actions/runs/9677013839/job/26697778265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments from the previous PRs. Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@anusreelakshmi934 Changes look good, but I think due to a recent PR merge from @aparnamichael (#849), there are now conflicts that need to be resolved. |
ccdf472
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks
bfd5030
into
OpenLiberty:lsp4ij-market-0.0.2-integration
Part of #666
Fixes Build lsp4ij plugin from a branch to use in the LTI automated tests #758 - Build lsp4ij plugin from a branch to use in the LTI automated tests
Checkout any branch of
lsp4ij
(main or any merge commit SHA) and use thebuildPlugin
command to create a ZIP file from it. Unzip the file and specify the path to thelib
folder as a plugin dependency inbuild.gradle
.Fixes Set up a GHA workflow as a cron job #756 - Set up a cron job to run every midnight
Created a new YAML file named
cronJob.yaml
with theuseLocalPlugin
value set totrue
. This configuration ensures that the cron job will execute the LTI build withuseLocalPlugin=true
.Fixes Determine Parameterization for Running the LTI Build #783 - Parameterize LTI Build.
Build and run tests using lsp4ij either (1) from the marketplace or (2) locally. Added a
workflow_dispatch
event so that we can check theuseLocalPlugin
as true or false.Fixes Run the LTI Tests against each open lsp4ij PR and lsp4ij main branch #757 - Fetch and checkout sha of each opened PR in lsp4ij and run LTI builds.
Added a job in the cronJob.yaml file to Extract merge_commit_shas of all the opened PRs in lsp4ij which are not in draft state. Created an array of sha values.
Run the LTI Tests for each extracted SHA in parallel, using a matrix strategy to handle multiple SHAs concurrently.
Also Run the LTI Tests against lsp4ij main branch