Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration of the Red Hat LSP4iJ plug-in #840

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Jun 25, 2024

Part of #666

  • Fixes Build lsp4ij plugin from a branch to use in the LTI automated tests  #758 - Build lsp4ij plugin from a branch to use in the LTI automated tests
    Checkout any branch of lsp4ij (main or any merge commit SHA) and use the buildPlugin command to create a ZIP file from it. Unzip the file and specify the path to the lib folder as a plugin dependency in build.gradle.

  • Fixes Set up a GHA workflow as a cron job #756 - Set up a cron job to run every midnight
    Created a new YAML file named cronJob.yaml with the useLocalPlugin value set to true. This configuration ensures that the cron job will execute the LTI build with useLocalPlugin=true.

  • Fixes Determine Parameterization for Running the LTI Build #783 - Parameterize LTI Build.
    Build and run tests using lsp4ij either (1) from the marketplace or (2) locally. Added a workflow_dispatch event so that we can check the useLocalPlugin as true or false.

  • Fixes Run the LTI Tests against each open lsp4ij PR and lsp4ij main branch #757 - Fetch and checkout sha of each opened PR in lsp4ij and run LTI builds.
    Added a job in the cronJob.yaml file to Extract merge_commit_shas of all the opened PRs in lsp4ij which are not in draft state. Created an array of sha values.
    Run the LTI Tests for each extracted SHA in parallel, using a matrix strategy to handle multiple SHAs concurrently.
    Also Run the LTI Tests against lsp4ij main branch

- Set up a cron job to run every midnight.
- Fetch and checkout sha of each opened PR in lsp4ij and run LTI builds.
- Parameterize LTI Build
build.gradle Outdated Show resolved Hide resolved
@anusreelakshmi934
Copy link
Contributor Author

mrglavas
mrglavas previously approved these changes Jun 26, 2024
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments from the previous PRs. Looks good!

.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
src/test/resources/ci/scripts/run.sh Show resolved Hide resolved
aparnamichael
aparnamichael previously approved these changes Jun 28, 2024
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

TrevCraw
TrevCraw previously approved these changes Jun 28, 2024
@TrevCraw
Copy link
Contributor

@anusreelakshmi934 Changes look good, but I think due to a recent PR merge from @aparnamichael (#849), there are now conflicts that need to be resolved.

Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@anusreelakshmi934 anusreelakshmi934 merged commit bfd5030 into OpenLiberty:lsp4ij-market-0.0.2-integration Jul 1, 2024
2 of 3 checks passed
@anusreelakshmi934 anusreelakshmi934 deleted the lsp4ijIntegration branch August 28, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants