Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #196 : Error message popup if Java 17 is not found to launch language servers #493

Merged
merged 11 commits into from
Sep 28, 2023
Merged

Fixes #196 : Error message popup if Java 17 is not found to launch language servers #493

merged 11 commits into from
Sep 28, 2023

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #196. Error message popup if Java 17 is not found to launch language servers .

TrevCraw
TrevCraw requested changes Sep 8, 2023
View reviewed changes
src/main/java/io/openliberty/tools/intellij/liberty/lsp/LibertyConfigLanguageServer.java Outdated Show resolved Hide resolved
...java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/server/ProcessStreamConnectionProvider.java Outdated Show resolved Hide resolved
...java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/server/ProcessStreamConnectionProvider.java Outdated Show resolved Hide resolved
...java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/server/ProcessStreamConnectionProvider.java Outdated Show resolved Hide resolved
...java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/server/ProcessStreamConnectionProvider.java Outdated Show resolved Hide resolved
...java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/server/ProcessStreamConnectionProvider.java Show resolved Hide resolved
src/main/resources/messages/LibertyBundles.properties Outdated Show resolved Hide resolved
src/main/java/io/openliberty/tools/intellij/util/Constants.java Outdated Show resolved Hide resolved
anusreelakshmi934 and others added 3 commits September 9, 2023 09:59
@anusreelakshmi934 @TrevCraw
Update src/main/java/io/openliberty/tools/intellij/util/Constants.java
34f94aa 
Co-authored-by: Trevor Crawford <[email protected]>
@anusreelakshmi934 @TrevCraw
Update src/main/java/io/openliberty/tools/intellij/lsp4mp/lsp4ij/serv…
0c37098 
…er/ProcessStreamConnectionProvider.java

Co-authored-by: Trevor Crawford <[email protected]>
@anusreelakshmi934
Changes mentioned OpenLiberty#196
a7e87ba 
The server files were modified.
changed to built in IntelliJ APIs to show pop up errors.
@anusreelakshmi934
changes#196
f404759 
checkJavaHome() made to return a boolean value. and modified the code according to other comments
@anusreelakshmi934
checkJavaHome return method OpenLiberty#196
498eab3 
added the boolean return method
@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Sep 19, 2023 •
edited
Loading

@TrevCraw Made the suggested changes.

@anusreelakshmi934 anusreelakshmi934 merged commit 586068e into OpenLiberty:main Sep 28, 2023
3 checks passed
@anusreelakshmi934 anusreelakshmi934 changed the title Fixes #196 Fixes #196 : Error message popup if Java 17 is not found to launch language servers Sep 28, 2023
@anusreelakshmi934 anusreelakshmi934 deleted the bugfix/#196 branch April 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrglavas mrglavas mrglavas left review comments

@dessina-devasia dessina-devasia dessina-devasia approved these changes

@TrevCraw TrevCraw TrevCraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deliver an error/warning message if Java 17 is not found to launch language servers
4 participants
@anusreelakshmi934 @mrglavas @TrevCraw @dessina-devasia