Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for null or empty class name in generate OpenAPI annotations #1011

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

turkeylurkey
Copy link
Member

In MicroProfileGenerateOpenAPIOperation we call PsiClass.getQualifiedName() which is nullable. It returns null when the class is local or a type parameter. In our test case we used a type parameter so we see the need to check the return type.

Fixes #995

@turkeylurkey turkeylurkey added the bug Something isn't working label Oct 9, 2024
@turkeylurkey turkeylurkey self-assigned this Oct 9, 2024
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should feed this back to Quarkus Tools since we're pulling this code from there.

@turkeylurkey turkeylurkey merged commit 4944c7d into OpenLiberty:main Oct 10, 2024
1 of 3 checks passed
@turkeylurkey turkeylurkey deleted the issue-995 branch October 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

NullPointerException from code action code using jakarta-sample
3 participants