Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle multimodule war webapp src directory missing in ear.xml fixed #913

Merged
merged 1 commit into from
Oct 9, 2024
Merged

gradle multimodule war webapp src directory missing in ear.xml fixed #913

merged 1 commit into from
Oct 9, 2024

Conversation

arunvenmany-ibm
Copy link
Contributor

No description provided.

@cherylking
Copy link
Member

Can you add an image of what the generated xml file looks like before/after this fix?

@arunvenmany-ibm
Copy link
Contributor Author

arunvenmany-ibm commented Oct 9, 2024 •
edited
Loading

@cherylking
this is the webapp directory structure
image

before changes, ear.xml is as follows
image
Due to this, war webapp resources were not loading in deployed ear
image

after changes
image
showing index.jsp contents
image

mattbsox
mattbsox approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@mattbsox mattbsox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@cherylking cherylking merged commit 2906113 into OpenLiberty:main Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

@mattbsox mattbsox mattbsox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunvenmany-ibm @cherylking @mattbsox