Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devc command line properties persist between Gradle runners #869

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

mattbsox
Copy link
Member

@mattbsox mattbsox commented Dec 7, 2023

Fix command line properties, such as --containerBuildTimeout=1234, not persisting between Gradle runners.
Properties would reset to default or the value set in the project build file when goals were invoked through a new Gradle instance.

Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no changes were needed on the Gradle BuildLauncher?

@mattbsox
Copy link
Member Author

mattbsox commented Dec 8, 2023

Didn't end up needing changes with the Gradle BuildLauncher since the DevExtension values get passed to the launcher's new project.

@mattbsox mattbsox merged commit 906defc into OpenLiberty:main Dec 8, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants