Additional support for multi-module loose ear applications #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
requested changes
Mar 28, 2023
src/main/groovy/io/openliberty/tools/gradle/tasks/DeployTask.groovy
Outdated
Show resolved
Hide resolved
...sources/multi-module-loose-ear-test/ejb-war/src/main/java/wasdev/ejb/ejb/web/EJBServlet.java
Outdated
Show resolved
Hide resolved
src/main/groovy/io/openliberty/tools/gradle/utils/LooseEarApplication.groovy
Show resolved
Hide resolved
mattbsox
force-pushed
the
multi-module-ear
branch
4 times, most recently
from
4c9d422
to
71e48d7
Compare
mattbsox
force-pushed
the
multi-module-ear
branch
from
71e48d7
to
8e75ef2
Compare
cherylking
requested changes
Apr 10, 2023
| if (OSUtil.isWindows()) { | ||
| projectPath = projectPath.replace("\\", "") | ||
| } else { | ||
| projectPath = projectPath.replace("/", "") |
There was a problem hiding this comment.
Why are the forward/backward slashes in the projectPath getting replaced with nothing? Is this just getting rid of a leading slash? If so, a substring might be better. If not, I don't understand how we can just get rid of all slashes in the projectPath.
There was a problem hiding this comment.
Yeah, that was just for the leading slash. I can try with a substring instead.
mattbsox
force-pushed
the
multi-module-ear
branch
from
8e75ef2
to
b404ade
Compare
mattbsox
force-pushed
the
multi-module-ear
branch
from
b404ade
to
70c8acc
Compare
cherylking
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loose ear logic will now check for additional project dependencies inside of war project dependencies and handle them accordingly.