Update devc metadata file write behavior for container build and start #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
requested changes
Nov 10, 2023
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/AntTaskFactory.java
Outdated
Show resolved
Hide resolved
cherylking
reviewed
Nov 10, 2023
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
mattbsox
force-pushed
the
podmanBuild
branch
from
bbf06ea
to
c72e12f
Compare
mattbsox
changed the title
cherylking
requested changes
Nov 13, 2023
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
Outdated
Show resolved
Hide resolved
mattbsox
force-pushed
the
podmanBuild
branch
from
c72e12f
to
2d0fd94
Compare
mattbsox
force-pushed
the
podmanBuild
branch
from
2d0fd94
to
6bbddc4
Compare
cherylking
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed writers not closing fully in
writeDevcMetadata()and changedexecContainerCmdAndLog()to only write devc metadata file on container start/stop commands.Fixes: OpenLiberty/ci.maven#1746