-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom-in feature: d3 approach #7
Open
Konstiman
wants to merge
27
commits into
master
Choose a base branch
from
feature-zoom-d3-jan
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the
d3
library to animate the zoom-in and zoom-out functionality.I tried it on Chrome and Firefox. The performance is better than the previous version and it also behaves more like the current Headstart.
I had to rewrite the
Paper
andBubble
components to class components.For the components that are mounted during the animation run, it was necessary to store the previous zoom values.
It was also needed to somehow track whether the animation is running or not. That's why I added the
animationLock
property and a timer into theUIStore
. Next time I'd do it differently though - probably similarly to the current Headstart, where the transitions increment and decrement some counter.I already know about some bugs:
There is a warning saying an unmounted component is updated. This can be probably solved by stopping the transition on=> solvedcomponentWillUnmount()
When resizing the window, the papers jump out of the bubbles. I'll try to debug this.=> solvedSome things could have been done better (e.g. the function
updateZoomStateAnimated
could be refactored into much smaller piece of code), but I think that can be done during the final implementation.