Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add reusable workflows #78

Merged

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

We have moved the functional code for the workflows to the organization .github repository to be called as reusable workflows. This allows us to reduce the amount of locations code needs to be modified for workflow changes.

What was the solution? (How)

  1. Remove reuse_python_build.yml since this is now stored in the .github repository
  2. Change the bump, publish, code quality workflows to call the reusable workflows in the .github repository

What is the impact of this change?

workflows in this repository now call reusable repositories from the .gihtub repository

How was this change tested?

Tested in a development org and repository

Was this change documented?

no

Is this a breaking change?

no


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@moorec-aws moorec-aws force-pushed the moorec/reusable_workflows branch from ed9a615 to 177552a Compare April 22, 2024 18:09
@moorec-aws moorec-aws marked this pull request as ready for review April 22, 2024 19:22
@moorec-aws moorec-aws requested a review from a team as a code owner April 22, 2024 19:22
.github/workflows/release_publish.yml Outdated Show resolved Hide resolved
@moorec-aws moorec-aws force-pushed the moorec/reusable_workflows branch from 177552a to 4bb35d2 Compare April 23, 2024 15:44
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.9', '3.10', '3.11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also testing 3.12 in this repo, but it's missing here -- it was in the reuse_python_build.yml file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@moorec-aws moorec-aws force-pushed the moorec/reusable_workflows branch from 4bb35d2 to 239b325 Compare April 23, 2024 16:22
Signed-off-by: Charles Moore <[email protected]>
@moorec-aws moorec-aws force-pushed the moorec/reusable_workflows branch from 239b325 to 6cbb219 Compare April 23, 2024 16:29
@moorec-aws moorec-aws merged commit c5836ce into OpenJobDescription:mainline Apr 23, 2024
15 checks passed
@moorec-aws moorec-aws deleted the moorec/reusable_workflows branch April 23, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants