feat!: Update openjd-cli to pass template_dir/cwd to preprocess_job_parameters #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
force-pushed
the
markw/update-preprocess-job-params
branch
from
22cdaff to
35c89a0
Compare
AWS-Samuel
previously approved these changes
Jan 17, 2024
epmog
previously approved these changes
Jan 17, 2024
mwiebe
force-pushed
the
markw/update-preprocess-job-params
branch
2 times, most recently
from
3edf35a to
8ecee03
Compare
…arameters * Update the openjd-sessions dependency to 0.3.* * Modify the use of preprocess_job_parameters, and the tests, to account for the upstream change * Update to reflect type changes from openjd-sessions * Add Python 3.12 and Windows to the gihub actions configuration. Signed-off-by: Mark Wiebe <[email protected]>
mwiebe
force-pushed
the
markw/update-preprocess-job-params
branch
from
8ecee03 to
ad7c329
Compare
epmog
approved these changes
Jan 19, 2024
ddneilson
approved these changes
Jan 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The breaking change in OpenJobDescription/openjd-model-for-python#39
requires an update to openjd-cli
What was the solution? (How)
Update the
openjd runcommand to pass the required directories to preprocess_job_parameters.What is the impact of this change?
The CLI will work once both the model and this change are merged.
How was this change tested?
Updated the unit tests and verified they run. Note I had to increase the timeout from 30 to 60 seconds, seems like running a session is slower on Windows.
I ran a job with both a template path parameter relative path default and a CLI parameter relative path, and confirmed that it works now, compared to before this breaking change when it failed.
Was this change documented?
No
Is this a breaking change?
Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.