feat: Adding optional override for adaptor request timeout default to EntryPoint start method #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… EntryPoint start method Signed-off-by: unknown <[email protected]>
Signed-off-by: Brian Axelson <[email protected]>
Signed-off-by: Brian Axelson <[email protected]>
|
crowecawcaw
approved these changes
Oct 23, 2024
AuxinJeron
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In some DCCs such as Unreal the default request timer maximum of 5 seconds is not long enough to handle some extremely resource intensive processes which occur during or shortly after startup such as asset discovery.
What was the solution? (How)
Provide an optional override which can be set in our DCC integrations adaptors to extend the timer when appropriate.
What is the impact of this change?
Adaptors won't time out waiting for responses from the openjd back end.
How was this change tested?
New test added, existing tests pass, manual testing.
Yes
Was this change documented?
No
Yes
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.