fix: Forward path mapping rules to backend process #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Gerveshi <[email protected]>
Signed-off-by: Alex Gerveshi <[email protected]>
Signed-off-by: Alex Gerveshi <[email protected]>
agerveshi
force-pushed
the
agerveshi/backend_path_mapping
branch
from
c3008b6 to
c23ac6a
Compare
Signed-off-by: Alex Gerveshi <[email protected]>
rcajigal
approved these changes
Oct 9, 2023
amznestebanpapp
approved these changes
Oct 9, 2023
Honglichenn
pushed a commit
that referenced
this pull request
Jan 17, 2024
…#11) * chore(github): Bump aws-actions/configure-aws-credentials from 2 to 4 Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 2 to 4. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v2...v4) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When running in daemon mode, the path mapping rules were not being forwarded from the frontend runner to the backend runner. Integration clients that rely on the adaptor's http_server for path mapping were failing, as the path mapping rules on the backend were empty.
What was the solution? (How)
Provide the path mapping data to the Frontend running during initialization so they can be passed to the backend process.
What is the impact of this change?
The backend process contains the path mapping rules and is able to provide them to the client.
How was this change tested?
Was this change documented?
Updated docstring.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.