Skip to content

Commit

Permalink
fix: set correct permission for the test directory.
Browse files Browse the repository at this point in the history
Signed-off-by: Hongli Chen <[email protected]>
  • Loading branch information
Honglichenn committed Apr 4, 2024
1 parent 6fc9bdd commit f4243ca
Showing 1 changed file with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,18 @@ def mock_runtime_logger_level(self, tmpdir: pathlib.Path):

@pytest.fixture
def connection_file_path(self, tmp_path: pathlib.Path) -> str:
return os.path.join(tmp_path.absolute(), "connection.json")
connection_dir = os.path.join(tmp_path.absolute(), "connection_dir")
os.mkdir(connection_dir)
if OSName.is_windows():
# In Windows, to prevent false positives in tests, it's crucial to remove the "Delete subfolders and files"
# permission from the parent folder. This step ensures that files cannot be deleted without explicit delete
# permissions, addressing an edge case where the same user owns both the parent folder and the file,
# bypassing delete permissions. `set_file_permissions_in_windows` will restrict the permission to read,
# write, delete current folder, which meets the requirement.
from openjd.adaptor_runtime._utils._secure_open import set_file_permissions_in_windows

set_file_permissions_in_windows(connection_dir)
return os.path.join(connection_dir, "connection.json")

@pytest.fixture
def initialized_setup(
Expand Down

0 comments on commit f4243ca

Please sign in to comment.