Performance improvements and new features #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the vtk.js rendering synchronous when changing timesteps, this change ensures the user moves through timesteps as fast as their machine can handle, and that each time step finishes rendering before moving to the next. Also, the two mechanisms by which time step scanning is achieved (left/right arrow keys and single arrow press+hold) now use the same underlying functionality and thus behave the same.
This provides support for the previously used csv file format, as well as the new json format. If a csv file is provided, it is converted to the json format before loading.
scottwittenburg
force-pushed
the
flatten-session-tree
branch
from
ce4559c to
f16a58f
Compare
By using a setTimeout in WindowControl currentDataset watcher, we fix the problem with the user-defined slices getting reset (in the VtkViewer) between datasets, when we are in userDefinedValues mode in the WindowControl component.
Also fix some lint errors
scottwittenburg
changed the title
|
As we discussed last week, I'm just going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionTreedata structurevue-utilitiescode into this repo as it seems now defunctThis set of changes requires changes invtk.js(here) andvue-utilties(here).The
vtk.jschange was merged into master and thevue-utilitiescode was moved into this repo.