Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft Delete callback #3

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

skrishnegowda
Copy link

No description provided.

@kelaraj
Copy link

kelaraj commented Jan 28, 2017

Nice implementation. My understanding is these changes will be completely backwards compatible because they are only invoked if a consumer of this gem specifies before_soft_destroy or after_soft_destroy. Is my understanding correct?

We'll obviously need to run our Delphius test suite (I assume that's our only internal consumer of this gem) with this new version just to confirm that there are no issues.

It'd also be great to add some tests to test_core.rb.

@christopherchiu you mentioned that you're pretty familiar with this gem. Any concerns?

@christopherchiu
Copy link

This looks good. Awesome job remembering to update the README file. Like @dpmehta02 said, we should add a test to make sure the callback is getting called.

@jpterry jpterry changed the base branch from pavlos-fix-build to opengov-master February 1, 2017 00:41
@jpterry jpterry merged commit 458d725 into OpenGov:opengov-master Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants