BUD-3634 add input to copy paths to env branch #1

alexkhromychenko · 2024-05-24T19:08:25Z

No description provided.

schmidtjohannes · 2024-05-27T14:52:02Z

action.yml

+    description: |
+      Copy specified paths to branch.
+      Input format: JSON list of objects string with fields: if, source and target.
+      Example: [{"if": true, "source": "path/to/source1", "target": "path/to/target1"}]


is this is a folder or a file?

what is the if for?

may it happen that source and target path are different?

is this a relative path? relative to what?

can we do something like

include-paths: - source: local/path target: target/folder1 - source: local/path2 target: target/folder2

can we even copy files to the root target folder?

is this is a folder or a file?
can be folder or a file

what is the if for?
if is used to add some condition if needed, for example if we want to copy files for wf-budget service but do not want for others

may it happen that source and target path are different?
yes, it's going to be different

is this a relative path? relative to what?
path should be relative to repository root

can we do something like
no, github action input do not support objects, we need to use JSON

can we even copy files to the root target folder?
it should be root of the repo, so should not be any problem

no, github action input do not support objects, we need to use JSON
you mean Github Actions is yaml based and does not understand yaml lists as parameters?
what about https://stackoverflow.com/questions/65345432/github-actions-pass-list-of-variables-to-shell-script ?

if is used to add some condition if needed, for example if we want to copy files for wf-budget service but do not want for others
oh, right : we would need to add it here https://github.com/OpenGov/k8s-deployment-bnp/blob/main/.github/workflows/render-manifests.yaml#L83 and it would need a per project config so you could do something like

include-paths: [{"if": matrix.env == "wf-budget", "source": "path/to/source1", "target": "path/to/target1"}]

like that?

you mean Github Actions is yaml based and does not understand yaml lists as parameters?
yaml in general supports lists or object but GH action inputs do not. https://stackoverflow.com/questions/75420197/how-to-use-array-input-for-a-custom-github-actions
I've tried to search in stackoverflow and ask ChatGPT but it only proposes to use JSON

like that?
yes, that's correct

branch-and-stage.sh

schmidtjohannes · 2024-05-27T14:59:34Z

kustomize-build.sh

@@ -38,7 +38,7 @@ pushd "${RENDER_DIR}" || exit 1
 if [[ -s "${RENDER_FILE}" ]]; then
  # Split the rendered file into individual files for each resource
  # Invalid GitHub artifact path name characters: Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?
-  yq -s '.kind + "-" + (.apiVersion | sub("/", "_")) + "-" + (.metadata.name | sub("[:<>|*?/\\]", "_")) + ".yaml"' < "${RENDER_FILE}"
+  yq -s '.kind + "-" + (.apiVersion | sub("/", "_")) + "-" + (.metadata.name | sub("[:<>|*?/]", "_")) + ".yaml"' < "${RENDER_FILE}"


can you elaborate what the change implies and why it was necessary?

Those are changes copied from original repo that we forked from that were added recently

oh, ok. can you have that separated so we do not mix it up. That way it would also be easy to create PR for the original repo