support dapr-proxy mode #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
requested review from
tpiperatgod,
lizzzcai,
benjaminhuo,
wanjunlei and
webup
wrongerror
force-pushed
the
main
branch
4 times, most recently
from
968a967 to
46bce09
Compare
Signed-off-by: wrongerror <[email protected]>
benjaminhuo
approved these changes
Sep 22, 2022
lizzzcai
reviewed
Sep 22, 2022
| handler, err := daprd.NewService(fmt.Sprintf(":%s", port)) | ||
|
|
||
| var newService func(address string) (s dapr.Service, err error) | ||
| protocol := daprruntime.Protocol(os.Getenv(protocolEnvVar)) |
There was a problem hiding this comment.
why we are providing both HTTP and gRPC here?
There was a problem hiding this comment.
Just because developing dapr-proxy requires both grpc and http support (ff-nodejs using http).
lizzzcai
reviewed
Sep 22, 2022
| @@ -19,6 +21,7 @@ import ( | |||
|
|
|||
| const ( | |||
| defaultPattern = "/" | |||
| protocolEnvVar = "APP_PROTOCOL" | |||
There was a problem hiding this comment.
if I understand correctly, we will need to pass this environment variable via openfunction controller?
There was a problem hiding this comment.
Yeah, openfunction controller will set this envVar，when serving.annotations contains dapr.io/app-protocol: http. (only do so in one dapr-sidecar-per-function mode).
wrongerror
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daprHostfrom env vars, init daprClient based ondaprHostanddaprGRPCPort.Signed-off-by: wrongerror [email protected]