Add missing features, polish to SynchronousComputeService
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotsdl
changed the title
SynchronousComputeServiceSynchronousComputeService
Still need to modify claiming code yet.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 85.53% 84.96% -0.58%
==========================================
Files 21 21
Lines 1915 2088 +173
==========================================
+ Hits 1638 1774 +136
- Misses 277 314 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hmacdope
requested changes
Mar 21, 2023
…eartbeat Need at least a separate thread for heartbeat to avoid it being blocked by a long calculation.
…uests Instead, making expiry part of the heartbeat API call; should be fairly cheap, and should still get the desired effect.
heartbeat interval for SynchronousComputeService set to 300 seconds (5 min); expiry set to 1800 seconds (30 minutes)
dotsdl
added a commit
that referenced
this pull request
Mar 24, 2023
Very much a work in progress; will be a separate PR from #98
|
@mikemhenry do you have a favorite logging formatter you'd like us to use for compute service logs? |
yaml.load -> yaml.safe_load Co-authored-by: Hugo MacDermott-Opeskin <[email protected]>
Also put in better stop conditions for the service itself.
|
Ready for final review @hmacdope! |
Co-authored-by: Hugo MacDermott-Opeskin <[email protected]>
dotsdl
changed the title
SynchronousComputeServiceSynchronousComputeService
|
Changes complete @hmacdope! Ready for another review! |
|
Thanks @hmacdope! This PR is much better following your reviews. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34.