Added a test to check that ComputeService deregistration resets claimed Tasks to status waiting #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianmkenney really small PR; can I get a review from you at your convenience? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 82.24% 82.24%
=======================================
Files 26 26
Lines 3125 3125
=======================================
Hits 2570 2570
Misses 555 555 ☔ View full report in Codecov by Sentry. |
dotsdl
added this to the Release 0.4.0 - new features, optimizations, targeted refactors milestone
ianmkenney
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a sanity check on #123, since we haven't pinned down the conditions under which this occurs, but weren't explicitly testing that deregistration resets Task status to waiting.