-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify action_tasks
#249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 82.30% 81.86% -0.44%
==========================================
Files 26 26
Lines 3068 3066 -2
==========================================
- Hits 2525 2510 -15
- Misses 543 556 +13 ☔ View full report in Codecov by Sentry. |
Awesome work @ianmkenney! Is this ready for review? |
@dotsdl should be good for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent @ianmkenney! Merge when satisfied!
action_tasks
previously issued queries for each task to be actioned. This PR reduces this to a single query using theUNWIND
clause, while accounting for the potential order loss from theUNWIND
. Local tests show equal to improved performance depending on the number of tasks actioned. For