Make test env use latest release of openfe and gufe instead of main
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `openfe` and `gufe` are operating at regular release cadences, I think it makes sense for us to perform testing against the latest releases of these on `conda-forge` instead of testing against the `main` branches of them. In particular, this saves us the need of having to manually track their dependencies, such as the recently added `kartograf` dependency in `openfe`. I think this is generally a safe move, since we only ever deploy production envs with releases of these packages too (pinned to specific releases). The CI/test env still operates as a canary of upstream changes, but on a delay dependent on upstream releases compared to current state.
|
@mikemhenry thoughts on this? Any reasons why we might not want to go this route? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 82.85% 82.26% -0.59%
==========================================
Files 22 22
Lines 2735 2735
==========================================
- Hits 2266 2250 -16
- Misses 469 485 +16 ☔ View full report in Codecov by Sentry. |
mikemhenry
approved these changes
Nov 20, 2023
devtools/conda-envs/test.yml
Outdated
Comment on lines
9
to
10
| - gufe | ||
| - openfe |
There was a problem hiding this comment.
not blocking but doing >= for min versions we support would save us from pulling in something old by mistake
…ng to old versions
mikemhenry
reviewed
Nov 20, 2023
mikemhenry
reviewed
Nov 20, 2023
|
LGTM, only other thing would be remove the stuff commented out since it looks like it works without it |
Co-authored-by: Mike Henry <[email protected]>
|
Awesome, thanks @mikemhenry! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
openfeandgufeare operating at regular release cadences, I think it makes sense for us to perform testing against the latest releases of these onconda-forgeinstead of testing against themainbranches of them. In particular, this saves us the need of having to manually track their dependencies, such as the recently addedkartografdependency inopenfe.I think this is generally a safe move, since we only ever deploy production envs with releases of these packages too (pinned to specific releases). The CI/test env still operates as a canary of upstream changes, but on a delay dependent on upstream releases compared to current state.